Apply load improve #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisuresh
commented
Nov 23, 2024
| @@ -336,6 +336,27 @@ class Config : public std::enable_shared_from_this<Config> | |||
| // `APPLY_LOAD_BL_LAST_BATCH_LEDGERS`. | |||
| uint32_t APPLY_LOAD_BL_LAST_BATCH_SIZE = 100; | |||
|
|
|||
| uint32_t APPLY_LOAD_LEDGER_MAX_INSTRUCTIONS = 0; | |||
There was a problem hiding this comment.
Need to add comments and clear error messages for misconfiguration.
6 tasks
dmkozh
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I made some changes so we could test the new proposal. We don't need to merge this PR into yours.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)