Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constant names, Help the compiler detect value changes #30

Merged
merged 2 commits into from
Feb 24, 2020

Conversation

dmarkham
Copy link
Owner

After reading dominikh/go-tools#660 and alvaroloes/enumer#59

I Like the ideas and have put together something that address the issues.

@codecov-io
Copy link

codecov-io commented Feb 24, 2020

Codecov Report

Merging #30 into master will increase coverage by 0.92%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   65.21%   66.14%   +0.92%     
==========================================
  Files           3        3              
  Lines         437      449      +12     
==========================================
+ Hits          285      297      +12     
  Misses        140      140              
  Partials       12       12
Impacted Files Coverage Δ
enumer.go 100% <100%> (ø) ⬆️
stringer.go 61.22% <100%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56342fd...8d7221c. Read the comment docs.

@dmarkham
Copy link
Owner Author

@domsekotill I used your suggestion to build in the compile time check, I did not need to modify it that much to get it passing all the tests. Very slick idea 👍

@dmarkham dmarkham merged commit d46c853 into master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants