Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attributes validation #3

Merged
merged 9 commits into from
Oct 10, 2023
Merged

Attributes validation #3

merged 9 commits into from
Oct 10, 2023

Commits on Oct 7, 2023

  1. Extracted Attributes newtype.

    @dmackdev
    dmackdev committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    1a8da78 View commit details
    Browse the repository at this point in the history

  2. Showing error frame around duplicate attribute keys.

    @dmackdev
    dmackdev committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    5f102cc View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2023

  1. Passing in is_key_valid closure, and calculating attributes_valid fro… 

    …m reused map.
    @dmackdev
    dmackdev committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    daaba52 View commit details
    Browse the repository at this point in the history

  2. Storing counts as values instead of indices.

    @dmackdev
    dmackdev committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    28e24c6 View commit details
    Browse the repository at this point in the history

  3. Add caching for attributes key count map.

    @dmackdev
    dmackdev committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    98489c6 View commit details
    Browse the repository at this point in the history

  4. Extracted validity_frame module.

    @dmackdev
    dmackdev committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    95eec88 View commit details
    Browse the repository at this point in the history

  5. Module restructure.

    @dmackdev
    dmackdev committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    76c0917 View commit details
    Browse the repository at this point in the history

  6. Encapsulated validation logic in AttributesValidator.

    @dmackdev
    dmackdev committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    8c33a99 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Remove rust-toolchain action to let GH Workflows honour toolchain file.

    @dmackdev
    dmackdev committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    5522a82 View commit details
    Browse the repository at this point in the history