Remove lxml from DUO107 #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughdavenport
added a commit
to hughdavenport/semgrep-rules
that referenced
this pull request
May 18, 2022
As mentioned in semgrep#1086, defusedxml.lxml was only ever an example and is deprecated. I've created a PR on the dlint project at dlint-py/dlint#44.
defusedxml.lxml [was only ever an example](https://github.com/tiran/defusedxml#defusedxmllxml) and tiran/defusedxml#38.
hughdavenport
force-pushed
the
DUO107-fixes
branch
from
4af3486
to
716ddb3
Compare
|
Hi there, Good catch, thanks for bringing this to my attention. I agree with the spirit of this task, however I think it makes sense to wait until tiran/defusedxml#38 is fixed (i.e. |
minusworld
pushed a commit
to semgrep/semgrep-rules
that referenced
this pull request
May 20, 2022
As mentioned in #1086, defusedxml.lxml was only ever an example and is deprecated. I've created a PR on the dlint project at dlint-py/dlint#44.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defusedxml.lxml was only ever an example and tiran/defusedxml#38.