-
-
Notifications
You must be signed in to change notification settings - Fork 421
Tentative fix for Issue 7270 - needless qualifiers in TypeInfo.toString
#2374
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request and interest in making D better, @radcapricorn! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2374" |
A possible problem with fixing 7270 is that base TypeInfo.opEquals uses string equality. Lines 1060 to 1070 in e798185
|
That's actually a requirement for fixing it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lacks tests, but otherwise LGTM
@@ -1028,18 +1028,31 @@ struct OffsetTypeInfo | |||
TypeInfo ti; /// TypeInfo for this member | |||
} | |||
|
|||
enum ToStringContext |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DDOC comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@radcapricorn ping
I don't like this approach too too much, but something needs to be done, so it's a starting point. That issue is louder than it appears. If
typeid(X) == typeid(Y)
, then it better be thattypeid(X).toString() == typeid(Y).toString()
.I'm open to suggestions on other approaches.
Need more tests. And feedback!