enhance(errors): set dynamic ruleId based on ErrorKind

Signed-off-by: royalpinto007 <royalpinto007@gmail.com>
dlang · Nov 1, 2024 · 2b89c29 · 2b89c29
1 parent a2194b0
commit 2b89c29
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/compiler/src/dmd/sarif.d b/compiler/src/dmd/sarif.d
@@ -179,21 +179,27 @@ void generateSarifReport(const ref SourceLoc loc, const(char)* format, va_list a
 
     // Map ErrorKind to SARIF levels
     const(char)* level;
+    string ruleId;
     final switch (kind) {
         case ErrorKind.error:
             level = "error";
+            ruleId = "DMD-ERROR";
             break;
         case ErrorKind.warning:
             level = "warning";
+            ruleId = "DMD-WARNING";
             break;
         case ErrorKind.deprecation:
             level = "deprecation";
+            ruleId = "DMD-DEPRECATION";
             break;
         case ErrorKind.tip:
             level = "note";
+            ruleId = "DMD-NOTE";
             break;
         case ErrorKind.message:
             level = "none";
+            ruleId = "DMD-MESSAGE";
             break;
     }
 
@@ -258,7 +264,11 @@ void generateSarifReport(const ref SourceLoc loc, const(char)* format, va_list a
     // Results Array
     ob.writestringln(`"results": [{`);
     ob.level += 1;
-    ob.writestringln(`"ruleId": "DMD",`);
+
+    // Rule ID
+    ob.writestring(`"ruleId": "`);
+    ob.writestring(ruleId);
+    ob.writestringln(`",`);
 
     // Message Information
     ob.writestringln(`"message": {`);

diff --git a/compiler/test/fail_compilation/sarif_test.d b/compiler/test/fail_compilation/sarif_test.d
@@ -16,7 +16,7 @@ TEST_OUTPUT:
 			"executionSuccessful": false
 		}],
 		"results": [{
-			"ruleId": "DMD",
+			"ruleId": "DMD-ERROR",
 			"message": {
 				"text": "undefined identifier `x`"
 			},