bug-fixes for "Open URL" action

djaskowiak · Sep 20, 2021 · 3f7aaa2 · 3f7aaa2
1 parent b84371f
commit 3f7aaa2
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 14 deletions.
diff --git a/gulpfile.js b/gulpfile.js
@@ -10,7 +10,7 @@ var DIST = './dist';
 
 /* true = directy distribute to extension folder in QS, false = just distribute to dist */
 var toQlikFolder = true;
-var VERSION = process.env.VERSION || '0.1.8';
+var VERSION = process.env.VERSION || '0.1.9';
 
 function copyExtFiles() {
   return gulp.src('./dist/*').pipe(gulp.dest(`${pkg.qlikshare}/StaticContent/Extensions/${pkg.name}`));

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "advanced-kpi",
-  "version": "0.1.8",
+  "version": "0.1.9",
   "description": "Advanced-KPI is about creating a smart KPI object that fits to 90% of the needs of Qlik Sense users.",
   "homepage": "",
   "repository": "https://github.com/djaskowiak/advanced-kpi",

diff --git a/src/definition.js b/src/definition.js
@@ -1579,7 +1579,7 @@ define(['qlik'], function (qlik, utils) {
     expression: "optional",
     defaultValue: "Headline text",
     show: function (data) {
-      if (data.prop.actions.variable.switch || data.prop.actions.jump.switch || data.prop.actions.bookmark.switch) { return true; }
+      if (data.prop.actions.variable.switch || data.prop.actions.jump.switch || data.prop.actions.bookmark.switch || data.prop.actions.url.switch) { return true; }
     }
   };
 
@@ -1590,7 +1590,7 @@ define(['qlik'], function (qlik, utils) {
     expression: "optional",
     defaultValue: "Subline text",
     show: function (data) {
-      if (data.prop.actions.variable.switch || data.prop.actions.jump.switch || data.prop.actions.bookmark.switch) { return true; }
+      if (data.prop.actions.variable.switch || data.prop.actions.jump.switch || data.prop.actions.bookmark.switch || data.prop.actions.url.switch) { return true; }
     }
   };
 
@@ -1990,7 +1990,7 @@ define(['qlik'], function (qlik, utils) {
         label: 'If an action is set you can type in a head- and a subline to describe what is going to happen after clicking on the object.',
         component: 'text',
         show: function (data) {
-          if (data.prop.actions.variable.switch || data.prop.actions.jump.switch || data.prop.actions.bookmark.switch) { return true; }
+          if (data.prop.actions.variable.switch || data.prop.actions.jump.switch || data.prop.actions.bookmark.switch || data.prop.actions.url.switch) { return true; }
         }
       }
     }
@@ -2039,7 +2039,7 @@ define(['qlik'], function (qlik, utils) {
         component: 'text'
       },
       paragraph3: {
-        label: 'Version: 0.1.8',
+        label: 'Version: 0.1.9',
         component: 'text'
       }
     }

diff --git a/src/index.js b/src/index.js
@@ -74,7 +74,7 @@ export default {
 
     //Actions
     try {
-      if (!this.$scope.isInEdit && (layout.prop.actions.jump.switch || layout.prop.actions.variable.switch || layout.prop.actions.bookmark.switch)) {
+      if (!this.$scope.isInEdit && (layout.prop.actions.jump.switch || layout.prop.actions.variable.switch || layout.prop.actions.bookmark.switch || layout.prop.actions.url.switch)) {
         layout.prop.actions.hover = true;
         //eventlistener for Actions
         $element.find('.adv-kpi-overlay').on("click", function () {
@@ -92,12 +92,12 @@ export default {
           }
           //open URL
           if (layout.prop.actions.url.switch) {
-            if(layout.prop.actions.url.newtabset) {
-              window.open(layout.prop.actions.url.set,'_blank');
+            if (layout.prop.actions.url.newtabset) {
+              window.open(layout.prop.actions.url.set, '_blank');
             } else {
-              window.open(layout.prop.actions.url.set,'_self');
-            }    
-          }  
+              window.open(layout.prop.actions.url.set, '_self');
+            }
+          }
         });
       } else {
         layout.prop.actions.hover = false;