Prevent index from being deleted when a exception occurs #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
specialunderwear
requested changes
Nov 21, 2024
| @@ -129,7 +129,9 @@ def reindex(self): | |||
|
|
|||
| try: | |||
| yield self | |||
| finally: | |||
| except Exception: # pylint: disable=try-except-raise | |||
There was a problem hiding this comment.
In stead of:
try:
yield self
except Exception:
raise
else:
self.indexer.finish()
I think you can just write it like this:
yield self
self.indexer.finish()
But I think you have to consult with viggo why the finish was there in the finally block first.
There was a problem hiding this comment.
But I think you have to consult with viggo why the finish was there in the finally block first.
- I made this some time ago, but didn't think of errors when I made this. So the new logic is correct.
specialunderwear
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.