Skip to content

Commit

Permalink
MSVC feedback responses
Browse files Browse the repository at this point in the history
  • Loading branch information
jonahbeckford committed Feb 16, 2024
1 parent b5b1c91 commit 18c4ced
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/dkml.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ on:
workflow_dispatch:

jobs:
build:
build:
strategy:
matrix:
include: #
Expand Down
6 changes: 3 additions & 3 deletions config/cfg.ml
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@ let () =
in
let accelerate_flags =
match arch, ccomp_type_opt with
| `x86_64, Some ccomp_type when ccomp_type = "msvc" -> [ "-DACCELERATE" ]
| `x86_64, Some "msvc" -> [ "-DACCELERATE" ]
| `x86_64, _ -> [ "-DACCELERATE"; "-mssse3"; "-maes"; "-mpclmul" ]
| _ -> []
in
let ent_flags =
match arch, ccomp_type_opt with
| (`x86_64 | `x86), Some ccomp_type when ccomp_type = "msvc" -> [ "-DENTROPY" ]
| (`x86_64 | `x86), Some "msvc" -> [ "-DENTROPY" ]
| (`x86_64 | `x86), _ -> [ "-DENTROPY"; "-mrdrnd"; "-mrdseed" ]
| _ -> []
in
Expand All @@ -51,7 +51,7 @@ let () =
let warn_flags =
(* See #178, there may be false positives on ppc&s390 with no-stringop-overflow *)
match arch, ccomp_type_opt with
| _, Some ccomp_type when ccomp_type = "msvc" -> [ "/WX" ]
| _, Some "msvc" -> [ "/WX" ]
| (`ppc64, _) | (`s390x, _) -> [ "-Wno-stringop-overflow"; "-Werror" ]
| _ -> [ "-Werror" ]
in
Expand Down

0 comments on commit 18c4ced

Please sign in to comment.