Skip to content

Commit

Permalink
ci fix: Do not fixate DISKUV_OPAM_REPOSITORY
Browse files Browse the repository at this point in the history
It is better to let the latest version of dkml-workflows use its DEFAULT_DISKUV_OPAM_REPOSITORY_TAG which will be compatible (ie. almost always the same) with DEFAULT_DKML_COMPILER and more important the pins will all exist in the (default tag) diskuv-opam-repository.

It is too easy, especially because diskuv-opam-repository is now pruned to remove unused package versions, for some pins not to exist when DISKUV_OPAM_REPOSITORY was incorrect.
  • Loading branch information
Jonah Beckford committed Sep 12, 2024
1 parent 531c100 commit 12b99ee
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions .github/workflows/dkml.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,6 @@ jobs:
- name: Checkout code
uses: actions/checkout@v3

- name: Promote version on Windows host
if: startsWith(matrix.dkml_host_abi, 'windows_')
run: echo "DISKUV_OPAM_REPOSITORY=$(Get-Content ${env:GITHUB_WORKSPACE}/src/runtimelib/version.txt)" >> $env:GITHUB_ENV

- name: Promote version on Unix host
if: "!startsWith(matrix.dkml_host_abi, 'windows_')"
run: echo "DISKUV_OPAM_REPOSITORY=$(cat src/runtimelib/version.txt)" >> $GITHUB_ENV

- name: Cache DkML compilers code
uses: actions/cache@v3
id: cache-dkml-compilers
Expand Down

0 comments on commit 12b99ee

Please sign in to comment.