Fix incorrect base_url #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On pages bli-medlem and aktivering the base url is incorrect where it points to e.g. http://localhost/aktivering/ instead of http://localhost/. This makes the language image not to show correctly. This is also a security fix, HTTP_HOST variable can be modified by the user request, so best practice is to avoid using it or at least have a white list if used. More info about security issues can be found on http://shiflett.org/blog/2006/mar/server-name-versus-http-host
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On pages bli-medlem and aktivering the base url is incorrect where it points to e.g. http://localhost/aktivering/ instead of http://localhost/. This makes the language image not to show correctly.
This is also a security fix, HTTP_HOST variable can be modified by the user request, so best practice is to avoid using it or at least have a white list if used.
More info about security issues can be found on http://shiflett.org/blog/2006/mar/server-name-versus-http-host
Since this modifies the base_url it must be configured in config.inc where the application is deployed before doing this merge.