New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow string in scrollToId #153

Open

safareli wants to merge 3 commits into diogofcunha:master from safareli:patch-1

safareli commented Jan 22, 2021

NodeId can be string or number but scrollToId only allows number.

safareli added 3 commits

January 22, 2021 19:21


          allow string in scrollToId

ca6476e


          allow string in scrollToId

97f1033


          scrollToId: NodeId

716dcb9

coveralls commented Jan 22, 2021

Coverage remained the same at 94.498% when pulling 716dcb9 on safareli:patch-1 into 0a65dfb on diogofcunha:master.

Strandinator mentioned this pull request

fix: ensuring consistent interface for scrollToId #135

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet