Deprecate .find_by raising an error
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p8
force-pushed
the
find_by_bang
branch
2 times, most recently
from
94c2a3c
to
327bf7b
Compare
`.find_by` raises a `RemoteResource::HTTPNotFound` error if the resource can't be found. This is unexpected as `ActiveRecord::Base.find_by` doesn't raise when the record can't be found. `ActiveRecord::Base.find_by!` does raise an error. To make RemoteResource behave more like ActiveRecord and have separate finder methods that raise or return `nil` we can add a `.find_by!` method that raises and let `.find_by` return `nil` instead. As `.find_by` is used a lot, we deprecate it first. In version 2.0 we can make `.find_by` return `nil` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RemoteResource.find_byraises aRemoteResource::HTTPNotFounderror if the resource can't be found. This is unexpected asActiveRecord::Base.find_bydoesn't raise when the record can't be found.ActiveRecord::Base.find_by!does raise an error.Current implementation:
Having a
RemoteResource.find_bymethod that doesn't raise can be useful, as we currently rescue theRemoteResource::HTTPNotFounderror instead in a lot of places. To make RemoteResource behave more like ActiveRecord and have separate finder methods that raise or returnnilwe can add a.find_by!method that raises and let.find_byreturnnilinstead:As
.find_byis used a lot, we deprecate it first in this PR. In version 2.0 we can make.find_byreturnnilinstead.This PR: