Feat/add wep api client project #1513

Fargekritt · 2024-11-22T12:03:32Z

Description

Related Issue(s)

#{issue number}

Verification

Your code builds clean without any errors or warnings
Manual testing done (required)
Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

…n interface.

coderabbitai · 2024-11-22T12:03:39Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sonarcloud · 2024-11-22T12:08:12Z

Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

oskogstad · 2024-11-22T14:30:05Z

.github/workflows/ci-cd-pull-request.yml

+    runs-on: ubuntu-latest
+    timeout-minutes: 15
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: set PROJECT variable to point to project
+        run: |
+          PROJECT=$(find . -name '*Digdir.Library.Dialogporten.WebApiClient.csproj' -printf "%p"  -quit)
+          echo "PROJECT ${PROJECT}"
+          echo "PROJECT=${PROJECT}" >> $GITHUB_ENV


Skulle denne i en ny fil? 😇
Edit: Doh, ser det er draft .. så kanskje ikke klart enda 🙈

oskogstad · 2024-11-22T14:41:26Z

src/Digdir.Library.Dialogporten.WebApiClient/Digdir.Library.Dialogporten.WebApiClient.csproj

+    </PropertyGroup>
+
+    <ItemGroup>
+        <PackageReference Include="Altinn.ApiClients.Maskinporten" Version="9.2.0"/>


Har det funka med denne versjonen?
Dette er den .NET8-versjonen som ble deprecated/fjerna 🤔

Suggested change

<PackageReference Include="Altinn.ApiClients.Maskinporten" Version="9.2.0"/>

<PackageReference Include="Altinn.ApiClients.Maskinporten" Version="9.2.1"/>

Amund Myrbostad added 25 commits November 7, 2024 10:45

Added projects

2816212

Imported projects

6cf97b0

Patch Works

09895f6

Refactor for readability

8ebfde9

Now runs directly on generated files. couple of big issues still

da50e90

Using Reflection to add refit clients based on namespace and if its a…

6058d92

…n interface.

Updated refitter config to generate 1 file instead of 2

d1b3a7b

Merge branch 'main' into feat/add-WepApiClient-project

a90ae68

DialogToken verification added

f4791c9

Added GetDialogTokenClaims to extract the claims from a dialogToken

d95a42f

Added Stub readme

d622155

addded GetDialogTokenClaims input validation

1b1b998

Cleaned up unused usings

9164dc1

Cleanup and Updated README.md

5273421

Changed nameing startegy. updated readme

2ea0e22

Merge branch 'main' into feat/add-WepApiClient-project

a66a16c

Nuget testing

6e6a026

Added properties for nuget package

54bd597

Basic integration test like SwaggerSnapshot made

424285a

Created tests

dee1ced

Attempt to use asyns dispose to clean file after failed attempt

1059a6c

Working on tests

0a0338b

Merge branch 'main' into feat/add-WepApiClient-project

14510c3

Cleanup

28ff1b9

Created test workflow

d6c5346

Workflow test

cc4a709

oskogstad reviewed Nov 22, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/add wep api client project #1513

Feat/add wep api client project #1513

Fargekritt commented Nov 22, 2024

coderabbitai bot commented Nov 22, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

sonarcloud bot commented Nov 22, 2024

oskogstad Nov 22, 2024 •

edited

Loading

oskogstad Nov 22, 2024

	<PackageReference Include="Altinn.ApiClients.Maskinporten" Version="9.2.0"/>
	<PackageReference Include="Altinn.ApiClients.Maskinporten" Version="9.2.1"/>

Feat/add wep api client project #1513

Are you sure you want to change the base?

Feat/add wep api client project #1513

Conversation

Fargekritt commented Nov 22, 2024

Description

Related Issue(s)

Verification

Documentation

coderabbitai bot commented Nov 22, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

sonarcloud bot commented Nov 22, 2024

Quality Gate failed

oskogstad Nov 22, 2024 • edited Loading

Choose a reason for hiding this comment

oskogstad Nov 22, 2024

Choose a reason for hiding this comment

oskogstad Nov 22, 2024 •

edited

Loading