-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-cookiecut, move tests to root level #211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking into the CI tests.
Seems like there is a typo of
Created a PR: Billingegroup/release-scripts#45 Once the PR is merged, hopefully the CI passes. |
requirements/run.txt
Outdated
diffpy.structure | ||
diffpy.utils | ||
matplotlib-base | ||
numpy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed pinning since the latest release on conda-forge (diffpy.structure, diffpy.pdffit2 have no numpy pinning)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In proproject.toml
, however, still maintained below as discussed regarding the wx problem.
'Programming Language :: Python :: 3.10',
'Programming Language :: Python :: 3.11',
@sbillinge Just noticed that |
I reran the tests after merging main into v0 and the tests failed in the same way. @bobleesj Pls could you take a quick look. I think it is probably something very simple. |
(Still running tests using my own local fork) I will ping @sbillinge once ready for review. |
I think it's ready @sbillinge Had to pin numpy < 2 but made an issue |
Closes #209, #207, #175, #162, #37