Flake8 fixes pt3 #126
Closed
Flake8 fixes pt3 #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cadenmyers13 it's a drag I am afraid but every file we touch we should update the copyright statement at the top to give a date range ending in 2024 for the trustees of CU. |
sbillinge
reviewed
Jul 25, 2024
| @@ -319,7 +319,7 @@ def restrictConstrainedParameters(self): | |||
| """Set 'read-only' boxes that correspond to constrained parameters.""" | |||
|
|
|||
| self.setToolTips(tooltips.phasepanel) | |||
| txtbg = self.textCtrlA.DefaultStyle.BackgroundColour | |||
| # txtbg = self.textCtrlA.DefaultStyle.BackgroundColour | |||
There was a problem hiding this comment.
This change will change behavior. If flake8 is complaining about txtbg not being used, just remove the txtbg = from the beginning of the line.
| @@ -293,13 +301,19 @@ def onColClick(self, event): # wxGlade: TemperatureSeriesPanel.<event_handler> | |||
| column = event.GetColumn() | |||
| # sort by temperature | |||
| if column == 0: | |||
| sortkey = lambda tf: float(tf[0]) | |||
|
|
|||
| def sortkey(tf): | |||
There was a problem hiding this comment.
Define the function elsewhere then use it here
| sortkey = lambda tf: order[tf[1]] | ||
|
|
||
| def sortkey(tf): | ||
| return order[tf[1]] |
I see in your edit you had it as trustees of michigan state. Do we want to do both or just Columbia? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.