Flake8 fixes pt1 #124
Flake8 fixes pt1 #124
Conversation
There was a problem hiding this comment.
I hate to say this, but I think these are all wrong. We don't want to update copyright statements to either MSU or BNL, only adding/updating statements to Columbia.
The basic idea is that the copyright is owned by the entity that made the changes. Right now, since we are Columbia, Columbia owns copyright to changes we are making to the code now, but BNL/MSU don't have copyright for edits we are doing now (but still have copyright for the work done before), if you see what I mean.
| @@ -40,7 +40,7 @@ | |||
| computer programs for studying nanostructure in crystals, | |||
| J. Phys.: Condens. Matter 19, 335219 (2007).""" | |||
|
|
|||
| _copyright = "(c) 2005-{year},".format(year=__date__[:4]) | |||
| _copyright = "(c) 2005-2024-{year},".format(year=__date__[:4]) | |||
There was a problem hiding this comment.
this one probably doesn't need up updating. the {year} is doing that work.
|
reopening. Sorry, we just need to revert the copyright work on this PR. I think the rest is ok. Let's put all the copyright work on separate PRs. |
Ahh. I was wrestling with this earlier trying to revert my commits back to fix this. I thought I got it fixed in the PR but looks like I didn't😭. I will get this fixed. It's not too much work since I can search globally (command+f) on VS code and replace. |
|
this branch has conflicts too that needs resolving. We are approaching a point where it may be better to open a clean branch and redo the edits...... Especially since this will also include hte new work to get CI running. |
No description provided.