-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide info in doc and write an example page #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see inline comments. The examples send to be mostly the example code copy-pasted into the rst. See if there is an automatic way of doing that, but if not, please redo it to reflect the latest updated code.
I can write a python code for automating this process, but it's not necessary for this package because examples are kind of short. Ideally we can set a fixed template and conventions for example files and write a python code and put into the release-script repo. It could be helpful for other packages that have long examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Please check the examples.rst
in the docs. Does it still contain the old code or am I looking at an out of date version?
@sbillinge It's the updated version. Also I can make a issue in release script if we want to have the automated example builder. |
I see this in the example docs but didn't we move away from using pylab?
|
Yes thanks for the catch! sorry for the oversight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please could you make sure that the code in the docs works and let me know? I think copy-pasting the working code is maybe the best approach but I leave it up to you.
Add information on the documentation page.
I moved doc/examples into doc/source/examples and add an example page. I merged Ni_plot_pdf and Ni_calculation because they are mostly the same. I also update pylab plots to pyplot because The use of pylab is discouraged now