Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move dsl::exists into default feature #3937

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vnghia
Copy link
Contributor

@vnghia vnghia commented Feb 15, 2024

As discussed here: #3936 (reply in thread)

Copy link
Member

@weiznich weiznich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR 👍

The CI failures are related to rust-lang/rust#120830, which means we just need to wait until a fixed rust nightly version is released.

diesel/src/expression/mod.rs Show resolved Hide resolved
@vnghia
Copy link
Contributor Author

vnghia commented Feb 17, 2024

I found that our doc is built with i-implement-a-third-party-backend-and-opt-into-breaking-changes enabled so only this exists

#[cfg(feature = "i-implement-a-third-party-backend-and-opt-into-breaking-changes")]
pub mod exists;

is included in the doc and not the other one.

dsl::exists actually exists without i-implement-a-third-party-backend-and-opt-into-breaking-changes and i can use it normally. How should we address this confusion ?

@weiznich
Copy link
Member

dsl::exists actually exists without i-implement-a-third-party-backend-and-opt-into-breaking-changes and i can use it normally. How should we address this confusion ?

I would just rename that module to exist_implementation or something like that.

@vnghia
Copy link
Contributor Author

vnghia commented Feb 23, 2024

array_comparison also has this confusion as well. Should I fix in this PR as well ?

Edit: renaming seems to cause a lot of things to fail. I think it's better to wait for rust-lang/rust#1998

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants