Simplify icons structure #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move logo and logo-nightly to `icons/hicolor/scalable/apps` - add `gtkcord4.gresource.xml` and generated `gtkcord4.gresource` - remove `icons.gresource` - remove `pack-icons` module - remove `svg2png` script
- refactor `icons` module to only have `LoadResources` function - initialize resources in `main.go`
- regenerate `gtkcord4.gresource`
- add tooltips to `v.sendButton` and `b.menu` - change icon for `v.sendButton` to `paper-plane-symbolic` - change icon for `b.FolderIcon` to `folder-visiting-symbolic` - change default icon for `BackButton` to `sidebar-show-symbolic`
diamondburned
requested changes
Sep 28, 2023
I could probably make a script for this, but adding a new icon to GResource is just a matter of adding one extra line, like this one: <file preprocess="xml-stripblanks" alias="avatar-default-symbolic.svg">scalable/actions/avatar-default-symbolic.svg</file> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the way icons can be added to gtkcord4. It also removes all PNG icons and changes some of the icons to GNOME alternatives.