Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure sample data actually contains ID3v2.2 #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

founderio
Copy link

@founderio founderio commented Oct 25, 2021

Fixes #52

I've manually (with a hex editor) adjusted the content of the ID3v2.2 test file to match the spec defined here: https://id3.org/id3v2-00 (Linked from https://id3.org/Developer%20Information)

The file shows up correctly with the CLI now:

./tag -raw testdata/with_tags/sample.id3v22.mp3
Metadata Format: ID3v2.2
File Type: MP3
 Title: Test Title
 Album: Test Album
 Artist: Test Artist
 Composer: Test Composer
 Genre: Jazz
 Year: 2000
 Track: 3 of 6
 Disc: 2 of 0
 Picture: <nil>
 Lyrics: 
 Comment: Test Comment


"TYE": "2000"
"TCO": "(8)"
"COM": &tag.Comm{Language:"\x00\x00\x00", Description:"", Text:"Test Comment"}
"TT2": "Test Title"
"TP2": "Test AlbumArtist"
"TAL": "Test Album"
"TPA": "02"
"TRK": "03/06"
"TCM": "Test Composer"
"TP1": "Test Artist"

And also shows up correctly in other tools:
image
(Note that Ex Falso shows "Performer", which is an ongoing debate on their end (quid libet/ex falso map this to TP2/TPE2)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testdata/with_tags/sample.id3v22.mp3 seems to be a v2.3 tag
1 participant