Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add open button to app details page [DHIS2-13885] #564

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

amcgee
Copy link
Member

@amcgee amcgee commented Oct 29, 2024

Fixes DHIS2-13885

This adds a simple "Open" button to the top right of installed app pages in the App Management App, allowing the user to easily access the installed app (opening in a new tab)

Apps which are not yet installed or which don't have a launchUrl (for example plugins) don't display the button.

The design of this could be improved, but I think this is an important enough UX improvement to warrant deferring the perfect UI.

This also updates slightly the CSS rules to ensure the right column with app metadata doesn't shrink even on smaller screens.

Finally, the "Uninstall" button now has a secondary destructive style.

Screenshot 2024-10-29 at 12 23 56
Screenshot 2024-10-29 at 12 23 40

@amcgee amcgee requested a review from a team as a code owner October 29, 2024 11:29
@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-564--dhis2-app-management.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify October 29, 2024 11:37 Inactive
@amcgee amcgee merged commit f9854a2 into master Oct 29, 2024
8 of 10 checks passed
@amcgee amcgee deleted the feat-open-button branch October 29, 2024 12:06
dhis2-bot added a commit that referenced this pull request Oct 29, 2024
# [100.3.0](v100.2.40...v100.3.0) (2024-10-29)

### Features

* add open button to app details page [DHIS2-13885] ([#564](#564)) ([f9854a2](f9854a2))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants