CMake updates #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
find_package(GLUT) now sets GLUT_LIBRARIES instead of GLUT_LIBRARY
This code at least needs to be conditional as it does not work on Apple silicon chips. Disabling these commands had no obvious adverse effect, so I'm not sure the SSE instructions are ever explicitly called.
This still isn't working, it seems like create_test_sourcelist doesn't like to add tests in subdirectories. This may be why there were multiple calls to add_executable before. However, that does not work in new CMake. Perhaps there is another way to add additional files.
|
Thanks for these improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a variety of fixes updating the required CMake from 2.4 to 3.1 as well as other changes required to get things building without errors on my Mac.
The unit tests are still not configured in CTest properly.
This was only tested on MacOS / XCode. It is likely an improvement for other platforms and compilers, but of course needs testing.