fix: do not allow search submit if no terms entered #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcannon068nw
approved these changes
Oct 19, 2023
acoffman
approved these changes
Oct 19, 2023
| @@ -104,6 +104,9 @@ const SearchBar: React.FC<SearchBarProps> = ({ handleSubmit }) => { | |||
| } | |||
| }; | |||
| const handleSearchClick = () => { | |||
| if (selectedOptions?.length === 0) { | |||
There was a problem hiding this comment.
I was wondering if selectedOptions could be undefined and that would then cause this to be false and submit the form anyways, but it looks like its always set to [] as far as I can tell.
There was a problem hiding this comment.
yep, its default is always [] if the state is never changed! as long as no one ever changes any of the setSelectedOptions([]) to something other than [], we should be in the clear! Another potential issue could be if event.target.value is ever undefined... I don't see how that could happen unless there was some sort of data issue with the search suggestions, though.
katiestahl
added a commit
that referenced
this pull request
Oct 19, 2023
* fix: use correct indication attribute name (#408) * fix: add URL cites back (#409) * add release information component for footer * run prettier * cleanup: make about links consistent (#413) * make footer no longer sticky * fix: correct source versioning (#421) * fix: clean up GtoP import (#419) * fix: use latest GO address (#424) * feat: bump drugbank version (#422) * feat: alphabetize sources * refactor: alphabetize sources * style: running prettier to prettify the sort data function * fix: sort on pmid and source columns * feat: add sources to interaction page * feat: reduce precision of interaction score on interaction page to 2 decimal places * fix: fix typo (#444) * fix: do not allow search submit if no terms entered (#446) --------- Co-authored-by: James Stevenson <james.stevenson@nationwidechildrens.org> Co-authored-by: Adam Coffman <acoffman@wustl.edu>
katiestahl
added a commit
that referenced
this pull request
Oct 19, 2023
* disable strict build in github actions for now * set variable directly in build command * Automated frontend build * remove key entries if nil * auth differently when CI is set * add libraries required for ssh auth * removing stale file * Automated frontend build * Dev (#442) * fix: use correct indication attribute name (#408) * fix: add URL cites back (#409) * add release information component for footer * run prettier * cleanup: make about links consistent (#413) * make footer no longer sticky * fix: correct source versioning (#421) * fix: clean up GtoP import (#419) * fix: use latest GO address (#424) * feat: bump drugbank version (#422) * feat: alphabetize sources * refactor: alphabetize sources * style: running prettier to prettify the sort data function * fix: sort on pmid and source columns * feat: add sources to interaction page * feat: reduce precision of interaction score on interaction page to 2 decimal places --------- Co-authored-by: James Stevenson <james.stevenson@nationwidechildrens.org> Co-authored-by: Adam Coffman <acoffman@wustl.edu> * Automated frontend build * Dev (#447) * fix: use correct indication attribute name (#408) * fix: add URL cites back (#409) * add release information component for footer * run prettier * cleanup: make about links consistent (#413) * make footer no longer sticky * fix: correct source versioning (#421) * fix: clean up GtoP import (#419) * fix: use latest GO address (#424) * feat: bump drugbank version (#422) * feat: alphabetize sources * refactor: alphabetize sources * style: running prettier to prettify the sort data function * fix: sort on pmid and source columns * feat: add sources to interaction page * feat: reduce precision of interaction score on interaction page to 2 decimal places * fix: fix typo (#444) * fix: do not allow search submit if no terms entered (#446) --------- Co-authored-by: James Stevenson <james.stevenson@nationwidechildrens.org> Co-authored-by: Adam Coffman <acoffman@wustl.edu> * Automated frontend build * Automated frontend build --------- Co-authored-by: Adam Coffman <acoffman@wustl.edu> Co-authored-by: acoffman <acoffman@users.noreply.github.com> Co-authored-by: katiestahl <katiestahl@users.noreply.github.com> Co-authored-by: James Stevenson <james.stevenson@nationwidechildrens.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #415