-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve dfx start
messages.
#3946
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-dfinity
requested review from
ericswanson-dfinity and
lwshang
and removed request for
ericswanson-dfinity
October 9, 2024 03:59
Because new user often don't realize that they successfully ran dfx start and need to open a new terminal, I recommend making it even more clear. For dfx start: For dfx start --background: |
vincent-dfinity
requested review from
ericswanson-dfinity
and removed request for
lwshang
November 7, 2024 12:22
ericswanson-dfinity
previously approved these changes
Nov 12, 2024
ericswanson-dfinity
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dfx start
messages to let users know what to do next clearly.PostStart
actor which will be notified byPocketIcProxy
actor to output the messages in the right order.original_background
environment variable which will be used by the second start, as for now with--background
we will run thedfx start
again without--background
option, but we need its value in PostStart actor.Fixes # (issue)
SDK-1844
How Has This Been Tested?
Manually tests.
Also add e2e test for
dfx start --background
, not sure how to add test fordfx start
...Checklist: