Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: testing priority scheduler #9857

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

chore: testing priority scheduler #9857

wants to merge 8 commits into from

Conversation

ShreyaLnuHpe
Copy link
Contributor

@ShreyaLnuHpe ShreyaLnuHpe commented Aug 22, 2024

Ticket

Description

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Aug 22, 2024
Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit dd1d65a
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66ceec11a1c5330008f399b1

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 54.63%. Comparing base (640126b) to head (dd1d65a).
Report is 12 commits behind head on main.

Files Patch % Lines
master/internal/rm/agentrm/agent.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9857      +/-   ##
==========================================
- Coverage   54.64%   54.63%   -0.01%     
==========================================
  Files        1261     1261              
  Lines      156199   156214      +15     
  Branches     3589     3590       +1     
==========================================
- Hits        85353    85352       -1     
- Misses      70714    70730      +16     
  Partials      132      132              
Flag Coverage Δ
backend 45.12% <33.33%> (-0.02%) ⬇️
harness 72.60% <ø> (ø)
web 54.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
agent/internal/agent.go 0.00% <ø> (ø)
agent/internal/options/options.go 30.35% <100.00%> (+1.26%) ⬆️
master/internal/rm/agentrm/agent_state.go 84.02% <100.00%> (+0.17%) ⬆️
master/pkg/aproto/master_message.go 0.00% <ø> (ø)
master/internal/rm/agentrm/agent.go 24.89% <0.00%> (-0.53%) ⬇️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant