Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make in-house openapi generators more reusable #9806

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hamidzr
Copy link
Contributor

@hamidzr hamidzr commented Aug 7, 2024

Ticket

Description

Remove the dependency on determined package and BaseSession

https://hpe-aiatscale.slack.com/archives/C6D7MDSQ5/p1722972189991699

Test Plan

  • check the diff in the generated code it should just show a set of
  -    session: "api.BaseSession",
  +    session: "RequestHandler",

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Aug 7, 2024
Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit b6d5153
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66bce1ffa3de78000857adc5

@hamidzr hamidzr changed the title chore: make bindings more reusable chore: make in-house openapi generators more reusable Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.16%. Comparing base (f7e18fc) to head (b6d5153).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9806      +/-   ##
==========================================
- Coverage   54.27%   54.16%   -0.12%     
==========================================
  Files        1261      736     -525     
  Lines      155642   102646   -52996     
  Branches     3535     3534       -1     
==========================================
- Hits        84471    55594   -28877     
+ Misses      71033    46914   -24119     
  Partials      138      138              
Flag Coverage Δ
backend 43.77% <ø> (-1.13%) ⬇️
harness 56.06% <ø> (-16.56%) ⬇️
web 53.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 656 files with indirect coverage changes

@hamidzr hamidzr marked this pull request as ready for review August 12, 2024 22:01
@hamidzr hamidzr requested a review from a team as a code owner August 12, 2024 22:01
@hamidzr hamidzr marked this pull request as draft August 14, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant