-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented randomBigDecimal method #41
Conversation
Here's the code health analysis summary for commits Analysis Summary
|
Thank you for the PR 😄. The solution is valid but the result is not limited to two decimal places. Example of the actual implementation: Although, my intention was to use the datafaker library, if possible. I see that I left the link to the providers page and the one to use is here: datafaker number |
I will try implementing the datafaker library and i have to limit the decimal places upto two places right? |
I will make a new pull request for the changes you specified so may I close this request? |
If you make the changes in the same branch, the result appears here. It is not necessary to create another PR. |
oh ok thanks for letting me know , I am new to this. |
… random number between 1 to 1000 upto two decimal places.
I implemented the change. |
@KaroK365 Thanks 😊 |
Fixes #
Create "randomBigDecimal" method #35
Description
Implemented the randomBigDecimal method which generates random big decimal numbers between 1 and 1000, then used it in "src/test/java/dev/nmarulo/depensaapp/app/products/ProductServiceTestUtil.java" and "src/test/java/dev/nmarulo/depensaapp/app/shoppinglist/ShoppingListServiceTestUtil.java" to generate random Prices and Calories.
Also removed "import java.time.LocalDateTime" as i did not notice it being used.