Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented randomBigDecimal method #41

Merged
merged 3 commits into from
Oct 26, 2024
Merged

Conversation

KaroK365
Copy link
Contributor

Fixes #

Create "randomBigDecimal" method #35

Description

Implemented the randomBigDecimal method which generates random big decimal numbers between 1 and 1000, then used it in "src/test/java/dev/nmarulo/depensaapp/app/products/ProductServiceTestUtil.java" and "src/test/java/dev/nmarulo/depensaapp/app/shoppinglist/ShoppingListServiceTestUtil.java" to generate random Prices and Calories.

Also removed "import java.time.LocalDateTime" as i did not notice it being used.

Copy link
Contributor

deepsource-io bot commented Oct 25, 2024

Here's the code health analysis summary for commits 76b7372..795148c. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Java LogoJava✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗
DeepSource Docker LogoDocker✅ SuccessView Check ↗
DeepSource Secrets LogoSecrets✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@nmarulo nmarulo self-assigned this Oct 25, 2024
@nmarulo nmarulo linked an issue Oct 25, 2024 that may be closed by this pull request
@nmarulo
Copy link
Member

nmarulo commented Oct 25, 2024

Thank you for the PR 😄.

The solution is valid but the result is not limited to two decimal places. Example of the actual implementation: 243.94340437692452

Although, my intention was to use the datafaker library, if possible.

I see that I left the link to the providers page and the one to use is here: datafaker number

@KaroK365
Copy link
Contributor Author

I will try implementing the datafaker library and i have to limit the decimal places upto two places right?

@KaroK365 KaroK365 closed this Oct 26, 2024
@KaroK365 KaroK365 reopened this Oct 26, 2024
@KaroK365
Copy link
Contributor Author

I will make a new pull request for the changes you specified so may I close this request?

@nmarulo
Copy link
Member

nmarulo commented Oct 26, 2024

If you make the changes in the same branch, the result appears here. It is not necessary to create another PR.

@KaroK365
Copy link
Contributor Author

oh ok thanks for letting me know , I am new to this.

… random number between 1 to 1000 upto two decimal places.
@KaroK365
Copy link
Contributor Author

I implemented the change.

@nmarulo nmarulo added the hacktoberfest-accepted PR aceptadas para el hacktoberfest label Oct 26, 2024
@nmarulo
Copy link
Member

nmarulo commented Oct 26, 2024

@KaroK365 Thanks 😊

@nmarulo nmarulo merged commit d44ca98 into despensa-app:master Oct 26, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted PR aceptadas para el hacktoberfest Size: S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create "randomBigDecimal" method
2 participants