Add sound to keys #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a small PR just that adds sound to the keys only. None of the knobs or buttons were given functionality (yet). The sound was hidden behind a flag so that a user wouldn't start hitting buttons and wonder why knobs/buttons appear to not work since the keys do.
The sound was made possible with ToneJS, which adds a layer of organization over the WebAudio API.
To Test
To hear sound, add
?playSound=trueto the URL. It's currently a synth sound, but ToneJS makes it possible to swap in sound files (using Sampler) which can then make it possible to make it play a piano sound.