Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] 모집 안내 페이지 바로가기 섹션 추가 #279

Merged
merged 9 commits into from
Sep 20, 2023

Conversation

sumi-0011
Copy link
Member

작업 내용

  • 모집 안내 페이지 바로가기 섹션 PC, 모바일 반응형 구현

스크린샷

스크린샷 2023-09-19 오후 10 44 32 스크린샷 2023-09-19 오후 10 47 02

@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
www-depromeet-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 0:29am

@github-actions github-actions bot added the style change style or request it label Sep 19, 2023
@sumi-0011 sumi-0011 changed the base branch from develop to feat/journey September 19, 2023 13:49
@github-actions
Copy link

github-actions bot commented Sep 19, 2023

Bundle Sizes

Compared against d4bc7f9

Route Size (gzipped) Diff
/ 74.54 KB -7.72 KB
/404 71.89 KB -4.91 KB
/_app 118.2 KB -12.72 KB
/about 72.2 KB -12.73 KB
/project 78.15 KB -16.71 KB
/recruit 110.68 KB +25.44 KB
/contact no change removed
/project/[projectTitle] no change removed
/recruit/[position] no change removed
Dynamic import Size (gzipped) Diff
../components/project-detail/OtherProjectSection.tsx -> ../project/ProjectItem/ProjectItem no change removed

@github-actions
Copy link


export function RecruitEntrance() {
return (
<section css={[commonLayoutCss, layoutCss]}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기서 합쳐도 좋네요

Comment on lines 78 to 100
& > div:first-of-type {
width: 124px;
margin-left: 0;
img {
width: auto;
height: 170px;
left: -16px;
}
}
& > div:last-of-type {
gap: 8px;

h1 {
${theme.typos.pretendard.subTitle2};
}

p {
font-size: 14px;
}
button {
margin-top: 16px;
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요렇게 선택자로 css 주면, 변경에 덜 유연하지 않을까요?? html구조를 바꾸면 css도 수정해야할 것 같아요!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조금 수정했습니다!!

Copy link
Member

@kimyouknow kimyouknow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

css 선택자 관련된 의견만 봐주세요! 수정이 필요하기보단 얘기해보면 좋을 것 같아요 ㅎㅎㅎ

Base automatically changed from feat/journey to feat/layout-media September 20, 2023 12:17
Base automatically changed from feat/layout-media to develop September 20, 2023 12:17
@github-actions github-actions bot removed the style change style or request it label Sep 20, 2023
@depromeet-official
Copy link
Contributor

depromeet-official commented Sep 20, 2023

@github-actions
Copy link

@github-actions
Copy link

@sumi-0011 sumi-0011 merged commit 6eefa81 into develop Sep 20, 2023
10 checks passed
@sumi-0011 sumi-0011 deleted the feat/recruit-entrance branch September 20, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants