-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] 모집 안내 페이지 바로가기 섹션 추가 #279
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle SizesCompared against d4bc7f9
|
|
||
export function RecruitEntrance() { | ||
return ( | ||
<section css={[commonLayoutCss, layoutCss]}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기서 합쳐도 좋네요
& > div:first-of-type { | ||
width: 124px; | ||
margin-left: 0; | ||
img { | ||
width: auto; | ||
height: 170px; | ||
left: -16px; | ||
} | ||
} | ||
& > div:last-of-type { | ||
gap: 8px; | ||
|
||
h1 { | ||
${theme.typos.pretendard.subTitle2}; | ||
} | ||
|
||
p { | ||
font-size: 14px; | ||
} | ||
button { | ||
margin-top: 16px; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요렇게 선택자로 css 주면, 변경에 덜 유연하지 않을까요?? html구조를 바꾸면 css도 수정해야할 것 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
조금 수정했습니다!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
css 선택자 관련된 의견만 봐주세요! 수정이 필요하기보단 얘기해보면 좋을 것 같아요 ㅎㅎㅎ
📝 Changed routes:
Commit 3b7cac8 (https://depromeet-q2hm561vb-depromeet-official-site.vercel.app). |
작업 내용
스크린샷