[Feat] 모집 일정 컴포넌트 #259
Merged
[Feat] 모집 일정 컴포넌트 #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kimyouknow
approved these changes
Sep 16, 2023
|
|
||
| background-color: ${theme.colors.black800}; | ||
|
|
||
| & + & { |
There was a problem hiding this comment.
| } | ||
|
|
||
| const layoutCss = (theme: Theme) => css` | ||
| max-width: 960px; |
There was a problem hiding this comment.
max-width는 왠지 공통으로 관리해야할 것 같은데, 나중에 한번에 해도 될듯!
| & > span { | ||
| ${theme.typos.decimal.body1}; | ||
| background-color: ${theme.colors.black400}; | ||
| flex: 1; |
There was a problem hiding this comment.
css 고수네요,
flex:1어떤 기능이죠👀
부모 dom에 display:flex가 걸려있을 때만 적용이 되고,
flex : flex-grow, flex-shrink, flex-basis를 한 번에 쓸 수 있는 축약형 속성
flex : 1로 적용한다면,
flex: 1;
/* flex-grow: 1; flex-shrink: 1; flex-basis: 0%; */
저는 이 속성을 이용해서 맞게, &>span이라는 dom이 부모 컴포넌트에 꽉 차게 늘어날 수 있도록 설정하였습니다! (반응형을 위해)
| import { SectionTitle } from './index'; | ||
|
|
||
| const meta: Meta<typeof SectionTitle> = { | ||
| title: 'CATEGORY/SectionTitle', |
There was a problem hiding this comment.
Suggested change
| title: 'CATEGORY/SectionTitle', | |
| title: 'components/SectionTitle', |
어때요??ㅎㅎ
There was a problem hiding this comment.
어때요??ㅎㅎ
좋습니당! 다른 storybook 코드를 복붙해 사용한 부분이라,
다른 부분들도 통일하면 좋을 것 같아요!
|
에러 나는 것도 해결했어요! 특별한 건 아니구 변수명 바꾼 걸 최신화안해서 생긴 문제였습니다;; |
Co-authored-by: 김윤호 yunho <kimyouknow@naver.com>
Bundle SizesCompared against d4bc7f9
|
|
🚀storybook: |
99-zziy
approved these changes
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
스크린샷
질문
gray.400이 프로젝트에는black400으로 정의되어있는데, 의도하신 건지 궁금합니다. @99-zziy