[FEAT#18] 흔들 때 진동 구현 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- home_ui_setting 브랜치 누락 코드 추가
kkk5474096
approved these changes
Jan 2, 2024
| VibrationEffect.createWaveform(vibrationPattern, amplitudes, -1) // -1은 반복 없음을 의미 | ||
| vibrator.vibrate(vibrationEffect) | ||
| } else { | ||
| // API 26 미만에서는 강도 조절이 불가능하므로 간단한 진동 사용 |
There was a problem hiding this comment.
근데 저희 최소 SDK 28이라 이거 없어도 괜찮지 않나요??
There was a problem hiding this comment.
@kkk5474096
그렇긴 하네요. api 26이면 안드로이드 8.0, 2017년 출시인데
지금 minSdk 28은 특별한 의미 없이 임의로 고른 거라 바꿔도 되긴 합니다.
VibrationEffect가 api 26이상부터 지원하니 minSdk를 26으로 맞춰서 낮출까요?
There was a problem hiding this comment.
최소 버전은 기획 부분관련이라 소통해봐도 될거같아요~
kkk5474096
reviewed
Jan 2, 2024
| VibrationEffect.createWaveform(vibrationPattern, amplitudes, -1) // -1은 반복 없음을 의미 | ||
| vibrator.vibrate(vibrationEffect) | ||
| } else { | ||
| // API 26 미만에서는 강도 조절이 불가능하므로 간단한 진동 사용 |
There was a problem hiding this comment.
근데 저희 최소 SDK 28이라 이거 없어도 괜찮지 않나요??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
#17 브랜치 merge할 때 일부 코드가 누락되어 이 브랜치에서 추가해주었습니다. (쏘리)
이 브랜치 merge 후 main에서 새 브랜치 파주세요!
✨ 작업 내용
✨ PR 포인트
📸 스크린샷/동영상