[BSVR-256] 환경변수 관리를 위한 AWS Secret Manger 도입 - V2 #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pminsung12
commented
Sep 8, 2024
Comment on lines
+1
to
+10
| oauth: | ||
| kakaoClientId: ${KAKAO_CLIENT_ID} | ||
| kakaoAuthTokenUrlHost: ${KAKAO_AUTH_TOKEN_URL_HOST} | ||
| kakaoAuthUserUrlHost: ${KAKAO_AUTH_USER_URL_HOST} | ||
| kakaoRedirectUrl: ${KAKAO_REDIRECT_URL} | ||
| googleClientId: ${GOOGLE_CLIENT_ID} | ||
| googleClientSecret: ${GOOGLE_CLIENT_SECRET} | ||
| googleRedirectUrl: ${GOOGLE_REDIRECT_URL} | ||
| googleAuthTokenUrlHost: ${GOOGLE_AUTH_TOKEN_URL_HOST} | ||
| googleUserUrlHost: ${GOOGLE_AUTH_USER_URL_HOST} |
There was a problem hiding this comment.
이제 환경 변수들 중.앙.제.어. 들어갑니다~!
|
이렇게 간단한 작업을... 괜히 sdk로 하려다가 4,5일을 삽질했네 😭 😭 |
wjdwnsdnjs13
approved these changes
Sep 9, 2024
EunjiShin
reviewed
Sep 9, 2024
There was a problem hiding this comment.
와ㅋㅋㅋㅋㅋ 스크립트 간결해지는 것 봐ㅋㅋㅋㅋㅋㅋ 속이 시원하구만 👍
엉 그렇게 사용해도돼! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요 (필수)
🔨 작업 사항 (필수)
⚡️ 관심 리뷰 (선택)
🌱 연관 내용 (선택)
💻 실행 화면 (필수)