Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BSVR-232] 믹스패널 이벤트 추가 #165

Merged
merged 12 commits into from
Sep 1, 2024
Merged

[BSVR-232] 믹스패널 이벤트 추가 #165

merged 12 commits into from
Sep 1, 2024

Conversation

wjdwnsdnjs13
Copy link
Member

📌 개요 (필수)

  • Mixpanel 이벤트 추가

🔨 작업 사항 (필수)

  • Mixpanel 의존성 추가
  • application-mixpanel.yaml 추가
  • Mixpanel 이벤트 추가
    • 후기 좋아요 추이
    • 리뷰 등록 추이
    • (상세)리뷰 열람 추이
    • 리뷰 스크랩 추이
    • 확인하고 싶으면 육지행 구글 계정으로 믹스패널 접속하면 돼!

⚡️ 관심 리뷰 (선택)

  • 서버에서 진행하기로 했던 이벤트 중 2가지는 제외하기로 했어!
    • 가장 많은 후기 등록 유저의 등록 횟수
    • 팀 별 데이터 등록 갯수
    • 사유 : 크게 중요한 정보가 아닌데, 원하는 형태로 보여주기가 어려움
      • 믹스패널만으로는 보여주기 힘들고, 어드민 웹이나 API를 따로 제공해서 Swagger를 사용하는 등의 작업이 필요함.
      • 어드민 웹은 공수가 많이 들고, Swagger는 운영서버에서 제공하는 것이 좋지 않다고 결론이 내려짐!
      • 정은 누나와 논의 완료!

💻 실행 화면 (필수)

image

@wjdwnsdnjs13 wjdwnsdnjs13 added the ✨ Feature 기능 개발 label Aug 26, 2024
@wjdwnsdnjs13 wjdwnsdnjs13 self-assigned this Aug 26, 2024
# Conflicts:
#	usecase/src/main/java/org/depromeet/spot/usecase/service/review/ReadReviewService.java
#	usecase/src/main/java/org/depromeet/spot/usecase/service/review/scrap/ReviewScrapService.java
Copy link

github-actions bot commented Aug 26, 2024

Test Results

53 tests  ±0   53 ✅ ±0   5s ⏱️ ±0s
18 suites ±0    0 💤 ±0 
18 files   ±0    0 ❌ ±0 

Results for commit 6bb84cd. ± Comparison against base commit 4643b3a.

♻️ This comment has been updated with latest results.

@wjdwnsdnjs13
Copy link
Member Author

오류가 났는데 일단 로그인 v2가 급하다고 해서 그거부터 처리하고 수정하도록 할게...!ㅠㅠ

@EunjiShin EunjiShin added the ❌ do not merge 아직 merge하면 안되는 상태 label Aug 26, 2024
@EunjiShin EunjiShin marked this pull request as draft August 26, 2024 19:44
# Conflicts:
#	.gitignore
#	application/build.gradle.kts
#	application/src/main/java/org/depromeet/spot/application/common/config/SecurityConfig.java
#	application/src/main/resources/application.yaml
# Conflicts:
#	application/src/main/java/org/depromeet/spot/application/common/config/SecurityConfig.java
#	application/src/main/java/org/depromeet/spot/application/common/jwt/JwtAuthenticationFilter.java
@wjdwnsdnjs13 wjdwnsdnjs13 marked this pull request as ready for review September 1, 2024 13:52
@wjdwnsdnjs13 wjdwnsdnjs13 merged commit eeca5ac into main Sep 1, 2024
5 checks passed
@wjdwnsdnjs13 wjdwnsdnjs13 deleted the feat/BSVR-232 branch September 1, 2024 13:53
@wjdwnsdnjs13 wjdwnsdnjs13 removed the ❌ do not merge 아직 merge하면 안되는 상태 label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants