-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor imports #157
base: main
Are you sure you want to change the base?
Refactor imports #157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why rename this directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the components are all collated rather than knocking around in the root. Separate them from the configuration files etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to move source under src/
but the rename is testdata/posts/fifth.md
→ content/posts/fifth.md
, presumably calling it content
instead of testdata
has no impact on where the components are located. testdata
is intentionally named for test fixtures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry, thought I saw the comment attached to the above file.
My thought for the rename was that it was a better example of a sensible file name, that users can 'clone and go', But not a hill I would die on, happy to change it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest undoing the content
change and intead move testdata
to src/testdata
"@denoland/htm": "https://deno.land/x/htm@0.1.3/mod.ts", | ||
"@denoland/htm/plugins/color-scheme": "https://deno.land/x/htm@0.1.3/plugins/color-scheme.ts", | ||
"@denoland/htm/plugins/unocss": "https://deno.land/x/htm@0.1.3/plugins/unocss.ts", | ||
"@denoland/g_a": "https://deno.land/x/g_a@0.1.2/mod.ts", | ||
"@githubcontent/kt3k/callsites": "https://raw.githubusercontent.com/kt3k/callsites/v1.0.0/mod.ts", | ||
"@outdated/std-http": "https://deno.land/std@0.193.0/http/mod.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems weird (but not technically wrong) to give these fake scope names
"tasks": { | ||
"dev": "deno run --allow-net --allow-read --allow-env=NODE_DEBUG,NO_COLOR,FORCE_COLOR,TERM --watch --no-check ./content/main.tsx --dev", | ||
"test": "deno test --allow-net --allow-read --allow-env=NODE_DEBUG,NO_COLOR,FORCE_COLOR,TERM --no-check=remote", | ||
"serve": "deno run --allow-net --allow-read --allow-env --no-check ./content/main.tsx" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--no-check
and --no-check=remote
are not needed here and above in modern deno
No description provided.