perf(ext/websocket): optimize socket.send #16320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
aapoalas
reviewed
Oct 17, 2022
aapoalas
reviewed
Oct 17, 2022
littledivy
commented
Oct 17, 2022
| ); | ||
| } else { | ||
| queueMicrotask(() => { | ||
| this[_bufferedAmount] -= d; |
There was a problem hiding this comment.
WPT assume that data is sent on the next tick so we have to delay decrementing the buffered amount counter.
crowlKats
approved these changes
Oct 19, 2022
bartlomieju
added a commit
to bartlomieju/deno
that referenced
this pull request
Oct 31, 2022
This reverts commit 36307c4.
crowlKats
added a commit
to crowlKats/deno
that referenced
this pull request
Jan 20, 2023
This reverts commit 36307c4
crowlKats
added a commit
that referenced
this pull request
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #16315