Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, thanks you making this great package.
In my experience, it's rather difficult to make the color of texts suitable for both light and dark theme. For example, texts of deep grey look good on light theme, but hardly readable on dark theme.
Maybe we could support apply colors defined in colorScheme, e.g. primary, onPrimary, surface, onSurface, etc, to keep the same level of readability regradless of which theme is applied.
This PR might have a workaround for use cases like above, which defines a mapping for themed color, like:
...
There's also limitation: The exported json has to be manually modified, as the code has not idea about the developer's intention (a constant hex color, or a color picked from colorScheme)