-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: multiple fallback tutorial #316
base: master
Are you sure you want to change the base?
Conversation
Add tutorial that utilizes local transitions to local fallback nodes to handle fallbacks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears this PR is a release PR (change its base from master
if that is not the case).
Here's a release checklist:
- Update package version
- Change PR merge option
- Test modules without automated testing:
- Requiring telegram
api_id
andapi_hash
- Requiring
HF_API_KEY
- Requiring telegram
- Search for objects to be deprecated
("information_flow", "time_node"): | ||
cnd.exact_match(Message(text="time")), | ||
("information_fallback_node"): | ||
cnd.true() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script should be rewritten in a way that shows how using LOCAL
transitions simplifies script writing process.
The current script has exactly one transition to fallback node per flow so it is not clear how using LOCAL
helps.
If the script had several nodes that have to have a fallback then we could showcase that using LOCAL
saves time from writing the same transitions in every node as it is suggested in the next markdown cell.
}, | ||
|
||
"auth_fallback_node": { | ||
RESPONSE: Message(text="User not found."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the nodes from this flow fallback to this node. So this node is visited not only when user is not found but also, for example, when admin password is incorrect.
Description
Add tutorial that utilizes local transitions to local fallback nodes to handle fallbacks.
To Consider