Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disconnect client explicitly #25

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

bmingles
Copy link
Collaborator

@bmingles bmingles commented Jul 10, 2024

Client wasn't actually getting disconnected when user clicked disconnect button. I have introduced proper disposal logic to dispose all DH services as part of clearing caches.

Testing

Test 1

  • Start DH server
  • Connect to server from vscode
  • Disconnect via the status bar item
  • Should see "Disconnected from Deephaven server: ..." toast message
  • Kill server.
  • Should not see a new "Disconnected from Deephaven server..." toast message

Test 2

  • Start DH server
  • Connect to server from vscode
  • Kill server
  • Should see "Disconnected from Deephaven server..." toast message

resolves #22

@bmingles bmingles force-pushed the 22-actually-disconnect-client branch from 93dbc33 to 73ea46e Compare July 10, 2024 21:42
@bmingles bmingles marked this pull request as ready for review July 10, 2024 21:42
@bmingles bmingles requested a review from mofojed July 10, 2024 21:43
@bmingles bmingles merged commit 0e7d3b5 into main Jul 11, 2024
1 check passed
@bmingles bmingles deleted the 22-actually-disconnect-client branch July 11, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client doesn't actually disconnect when clicking disconnect button
2 participants