Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cleanup worker event handling #166

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

bmingles
Copy link
Collaborator

@bmingles bmingles commented Nov 1, 2024

  • Remove event handler when query is running or fails
  • Handle failed query starts and cleanup

resolves #158

@bmingles bmingles linked an issue Nov 1, 2024 that may be closed by this pull request
Base automatically changed from 32-private-key to main November 6, 2024 14:25
Copy link

github-actions bot commented Nov 6, 2024

End-to-end Test Summary

Tests 📝Passed ✅Failed ❌Skipped ⏭️Pending ⏳Other ❓Flaky 🍂Duration ⏱️
660000005:01:55
A ctrf plugin

Detailed Test Results

NameStatusmsFlaky 🍂
should default to the correct settingspassed ✅1919
should return custom settings: Empty configspassed ✅257
should return custom settings: Populated configspassed ✅106
should be able to load VSCodepassed ✅989
should only be visible when a supported file type is active: test.groovypassed ✅2885
should only be visible when a supported file type is active: test.pypassed ✅1113
A ctrf plugin

Failed Test Summary

No failed tests ✨

Flaky Test Summary

No flaky tests detected. ✨

@bmingles bmingles requested a review from mofojed November 6, 2024 14:54
@bmingles bmingles merged commit adf1047 into main Nov 12, 2024
4 checks passed
@bmingles bmingles deleted the 158-query-start-handler branch November 12, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle failed query startup + cleanup event handler
2 participants