Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Worker settings #157

Merged
merged 4 commits into from
Oct 22, 2024
Merged

feat: Worker settings #157

merged 4 commits into from
Oct 22, 2024

Conversation

bmingles
Copy link
Collaborator

@bmingles bmingles commented Oct 18, 2024

Enterprise settings now support an expanded config:

  • Optional server label
  • Experimental worker config - an object of optional worker settings that will drive PQ creation

Also fixed a small json schema bug for community settings that was breaking intellisense in settings.json

Testing
Simple config should still work:

"deephaven.enterpriseServers": [
  https://dev-vplus.int.illumon.com:8123/
]

Expanded config should drive server label in the server tree and / or worker creation settings:

"deephaven.enterpriseServers": [
  {
    "url": "https://dev-vplus.int.illumon.com:8123/",
    "label": "San Luis", // optional label
    "experimentalWorkerConfig": {
      // custom heap size
      "heapSize": 0.5
    }
  },
]

Copy link

github-actions bot commented Oct 18, 2024

End-to-end Test Summary

Tests 📝Passed ✅Failed ❌Skipped ⏭️Pending ⏳Other ❓Flaky 🍂Duration ⏱️
660000005:32:00
A ctrf plugin

Detailed Test Results

NameStatusmsFlaky 🍂
should default to the correct settingspassed ✅2221
should return custom settings: Empty configspassed ✅329
should return custom settings: Populated configspassed ✅139
should be able to load VSCodepassed ✅900
should only be visible when a supported file type is active: test.groovypassed ✅3646
should only be visible when a supported file type is active: test.pypassed ✅1481
A ctrf plugin

Failed Test Summary

No failed tests ✨

Flaky Test Summary

No flaky tests detected. ✨

@bmingles bmingles linked an issue Oct 18, 2024 that may be closed by this pull request
package.json Show resolved Hide resolved
@bmingles bmingles requested a review from mofojed October 18, 2024 19:47
@bmingles bmingles self-assigned this Oct 21, 2024
@bmingles bmingles merged commit 98dbf43 into main Oct 22, 2024
5 checks passed
@bmingles bmingles deleted the 79-2-worker-settings branch October 22, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch DHE js api from server
2 participants