Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle server disconnects / non-existing server #14

Merged
merged 8 commits into from
Jul 5, 2024

Conversation

bmingles
Copy link
Collaborator

@bmingles bmingles commented Jun 26, 2024

This PR improves the server connection experience / fixes some bugs:

  • Status bar item now shows Deephaven: Connecting... while a connection is being initialized (before it immediately showed as connected)
  • Status bar shows Deephaven: Disconnected if connection fails
  • If client disconnects due to server stopping or anything else that results in an Jsapi ide 'disconnect' event, the status bar will be updated to reflect the status
  • Updated status bar / quick pick menu icons

Testing

Setup
If you clone this repo and run npm install, you should be able to f5 to run the extension in debug mode.

Test Steps

  • Start a DH server on localhost:10000
  • Connect to server in extension. Should see status bar "Connecting..." then "Connected" status (the connecting status may happen too quickly to really see it).
  • Kill server
  • Should see status bar item switch to disconnected
  • Attempt to re-connect to stopped server
  • Should see "Connecting..." status for longer this time and then a "Failed to initialize Deephaven API" toast. Status should say "Disconnected"

fixes #4 fixes #5 fixes #6

@bmingles bmingles self-assigned this Jun 26, 2024
@bmingles bmingles requested a review from mofojed June 27, 2024 22:17
@bmingles bmingles marked this pull request as ready for review June 27, 2024 22:17
@bmingles bmingles changed the title fix: Handle server disconnects / non-existing server Handle server disconnects / non-existing server Jul 3, 2024
@bmingles bmingles changed the title Handle server disconnects / non-existing server fix: Handle server disconnects / non-existing server Jul 3, 2024
@bmingles bmingles merged commit 73818af into main Jul 5, 2024
3 of 4 checks passed
@bmingles bmingles deleted the 5-handle-non-existing-server branch July 5, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants