Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add render tests for dialog #1031

Merged
merged 1 commit into from
Nov 22, 2024
Merged

test: Add render tests for dialog #1031

merged 1 commit into from
Nov 22, 2024

Conversation

dgodinez-dh
Copy link
Contributor

closes #952

@dgodinez-dh dgodinez-dh requested review from a team and AkshatJawne and removed request for a team November 21, 2024 17:50
AkshatJawne
AkshatJawne approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@AkshatJawne AkshatJawne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dgodinez-dh dgodinez-dh merged commit 1d5eec9 into deephaven:main Nov 22, 2024
10 checks passed
@dgodinez-dh dgodinez-dh deleted the dag_DialogRender branch November 25, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkshatJawne AkshatJawne AkshatJawne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui.dialog render test
2 participants
@dgodinez-dh @AkshatJawne