Custom parsers / null literals should use pre-legalized names (issue #190) #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosak
force-pushed
the
kosak_legalizer-names
branch
2 times, most recently
from
8c1dc43
to
89bff04
Compare
kosak
force-pushed
the
kosak_legalizer-names
branch
from
89bff04
to
03ee646
Compare
devinrsmith
approved these changes
Nov 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #190
Not that #190 misidentifies the root cause as having to do with reserved keywords. This is not correct because the library doesn't care whether a column header is a reserved keyword. The actual root cause is an interaction between the user-supplied "legalizer" and user-specified parsers or null literals that are specified by column names. Specifically the question is whether column names mentioned in
CsvSpecs.Builder.putParserForNameandCsvSpecs.Builder.putNullValueLiteralsForNameshould refer to the name that the column had before it was transformed by the legalizer, or after. The expected behavior is "before", but prior to this fix the library was doing the "after" behavior.