fix: Expose TableSubscription.close() to JS (#6446) #6448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The close() method is only on `AbstractTableSubscription`, and it appears that it doesn't automatically get added to the JS API even though `TableSubscription` is defined as a `JsType` - Explicitly add the method to `TableSubscription` as well. - Fixes deephaven#6447
mofojed
added
NoDocumentationNeeded
NoReleaseNotesNeeded
nbauernfeind
previously approved these changes
Nov 29, 2024
niloc132
requested changes
Nov 30, 2024
There was a problem hiding this comment.
Please review #6452 so we can land that to main and cherrypick those changed instead - this way we don't need to redefine the method just to export it.
Also please avoid implementation details in javadoc, which is exported in the js/ts docs.
niloc132
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractTableSubscription, and it appears that it doesn't automatically get added to the JS API even thoughTableSubscriptionis defined as aJsTypeTableSubscriptionas well.