Make python timezone conversions handle more cases #5249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipkent
added
bug
jmao-denver
reviewed
Mar 13, 2024
jmao-denver
previously approved these changes
Mar 15, 2024
py/server/deephaven/time.py
Outdated
|
|
||
| # Try to get the time zone from the zone name | ||
| try: | ||
| return _JDateTimeUtils.parseTimeZone(str(tzi)) |
There was a problem hiding this comment.
datetime.tzinfo is an abstract class, so I'm not sure str(tzi) is guaranteed to be well-defined. It looks like tzinfo does not define a method for string conversion, so you hope that the subclass does: https://github.com/python/cpython/blob/a76288ad9ba715216a29c89e046846b3eaf0fab7/Lib/_pydatetime.py#L1231
jmao-denver
approved these changes
Mar 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4723