Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Changes for Dir Struct, Tagged Iterations, Metrics #317

Merged
merged 23 commits into from
Jul 12, 2024

Conversation

stanbrub
Copy link
Collaborator

@stanbrub stanbrub commented Jul 12, 2024

  • Added user-supplied metrics for queries and made metrics simpler
    • Added data.file.size user metric to Parquet tests
    • Reworked queries to allow joining metrics that are not present for every benchmark
  • Got rid of collection of before and after bean metrics (They didn't really provide insight)
  • Added iterations that run only on benchmark tests that have tag annotations (ex @Tag("Iterate")
  • Unified the directory structure for all categories in GCloud (ex. category/owner/set-label/run-label/)
    • Updated all workflows and query snippets to this effect
    • Wrote converters for each category; nightly, release, compare
  • Added default set labels for each category
    • adhoc blank: set-23YGkqB
    • nightly: 2024-07-11 (ex.
    • release and compare: 00.035.05
  • Default input properties are now specified at the top level workflow level regardless of category
  • SVG templates now generated to the 'set' directory and latest to the owner directory
    • Updated generation and README.md links
  • Reworked generator file names and added file-name hashes for looking up reusable data
  • Updated benchmark_tables.py and adhoc_tables.py in GCloud for use with the other snippets

@stanbrub stanbrub linked an issue Jul 12, 2024 that may be closed by this pull request
@stanbrub stanbrub merged commit 6a6975a into deephaven:main Jul 12, 2024
2 checks passed
@stanbrub stanbrub deleted the iterations-for-tagged-benchmarks branch July 12, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant