-
Notifications
You must be signed in to change notification settings - Fork 21
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
multi: Find voted/revoked tickets with GCS filters
Use dcrd and GCS filters to find voted/revoked tickets rather than using the dcrwallet TicketInfo RPC. Using TicketInfo was a bit flakey because wallets do not always correctly detect votes/revokes, and as a result VSP admins may notice that with this change vspd detects some historic voted/revoked tickets which TicketInfo never detected.
- Loading branch information
1 parent
618cfc7
commit 9be203c
Showing
6 changed files
with
365 additions
and
50 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,174 @@ | ||
| // Copyright (c) 2023 The Decred developers | ||
| // Use of this source code is governed by an ISC | ||
| // license that can be found in the LICENSE file.package main | ||
|
|
||
| package main | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| "github.com/decred/dcrd/blockchain/stake/v5" | ||
| "github.com/decred/dcrd/chaincfg/chainhash" | ||
| "github.com/decred/dcrd/txscript/v4/stdaddr" | ||
| "github.com/decred/dcrd/wire" | ||
| "github.com/decred/vspd/database" | ||
| ) | ||
|
|
||
| type spentTicket struct { | ||
| dbTicket database.Ticket | ||
| expiryHeight int64 | ||
| heightSpent int64 | ||
| spendingTx *wire.MsgTx | ||
| } | ||
|
|
||
| func (s *spentTicket) voted() bool { | ||
| return stake.IsSSGen(s.spendingTx) | ||
| } | ||
|
|
||
| // findSpentTickets attempts to find transactions that vote/revoke the provided | ||
| // tickets by matching the payment script of the ticket's commitment address | ||
| // against the block filters of the mainchain blocks between the provided start | ||
| // block and the current best block. Returns any found spent tickets and the | ||
| // height of the most recent scanned block. | ||
| func (v *vspd) findSpentTickets(toCheck database.TicketList, startHeight int64) ([]spentTicket, int64, error) { | ||
| params := v.cfg.netParams | ||
|
|
||
| dcrdClient, _, err := v.dcrd.Client() | ||
| if err != nil { | ||
| return nil, 0, err | ||
| } | ||
|
|
||
| endHeight, err := dcrdClient.GetBlockCount() | ||
| if err != nil { | ||
| return nil, 0, fmt.Errorf("dcrd.GetBlockCount error: %w", err) | ||
| } | ||
|
|
||
| if startHeight > endHeight { | ||
| return nil, 0, fmt.Errorf("start height %d greater than best block height %d", | ||
| startHeight, endHeight) | ||
| } | ||
|
|
||
| numBlocks := 1 + endHeight - startHeight | ||
|
|
||
| // Only log if checking a larger number of blocks to avoid spam. | ||
| if numBlocks > 5 { | ||
| v.log.Debugf("Scanning %d blocks for %s", | ||
| numBlocks, pluralize(len(toCheck), "spent ticket")) | ||
| } | ||
|
|
||
| // Get commitment address payment script for each ticket. | ||
| type ticketTuple struct { | ||
| dbTicket database.Ticket | ||
| pkScript []byte | ||
| } | ||
|
|
||
| tickets := make(map[chainhash.Hash]ticketTuple) | ||
| for _, ticket := range toCheck { | ||
| parsedAddr, err := stdaddr.DecodeAddress(ticket.CommitmentAddress, params) | ||
| if err != nil { | ||
| return nil, 0, err | ||
| } | ||
| _, script := parsedAddr.PaymentScript() | ||
|
|
||
| hash, err := chainhash.NewHashFromStr(ticket.Hash) | ||
| if err != nil { | ||
| return nil, 0, err | ||
| } | ||
|
|
||
| tickets[*hash] = ticketTuple{ | ||
| dbTicket: ticket, | ||
| pkScript: script, | ||
| } | ||
| } | ||
|
|
||
| spent := make([]spentTicket, 0) | ||
|
|
||
| for iHeight := startHeight; iHeight <= endHeight; iHeight++ { | ||
| iHash, err := dcrdClient.GetBlockHash(iHeight) | ||
| if err != nil { | ||
| return nil, 0, err | ||
| } | ||
|
|
||
| iHeader, err := dcrdClient.GetBlockHeader(iHash) | ||
| if err != nil { | ||
| return nil, 0, err | ||
| } | ||
|
|
||
| verifyProof := v.cfg.netParams.dcp5Active(iHeight) | ||
| key, filter, err := dcrdClient.GetCFilterV2(iHeader, verifyProof) | ||
| if err != nil { | ||
| return nil, 0, err | ||
| } | ||
|
|
||
| var iBlock *wire.MsgBlock | ||
| outer: | ||
| for ticketHash, ticket := range tickets { | ||
| if filter.Match(key, ticket.pkScript) { | ||
| // Filter match means the ticket is likely spent in block. Get | ||
| // the full block to confirm. | ||
| if iBlock == nil { | ||
| iBlock, err = dcrdClient.GetBlock(iHash) | ||
| if err != nil { | ||
| return nil, 0, err | ||
| } | ||
| } | ||
|
|
||
| // The regular transaction tree does not need to be checked | ||
| // because tickets can only be spent by vote or revoke | ||
| // transactions which are always in the stake tree. | ||
| for _, blkTx := range iBlock.STransactions { | ||
| if !txSpendsTicket(blkTx, ticketHash) { | ||
| continue | ||
| } | ||
|
|
||
| // Confirmed - ticket is spent in block. | ||
|
|
||
| spent = append(spent, spentTicket{ | ||
| dbTicket: ticket.dbTicket, | ||
| expiryHeight: ticket.dbTicket.PurchaseHeight + int64(params.TicketMaturity) + int64(params.TicketExpiry), | ||
| heightSpent: iHeight, | ||
| spendingTx: blkTx, | ||
| }) | ||
|
|
||
| // Remove this ticket and continue with the next one. | ||
| delete(tickets, ticketHash) | ||
| continue outer | ||
| } | ||
|
|
||
| // Ticket is not spent in block. | ||
| } | ||
| } | ||
|
|
||
| if len(tickets) == 0 { | ||
| // Found spenders for all tickets, stop searching. | ||
| break | ||
| } | ||
| } | ||
|
|
||
| return spent, endHeight, nil | ||
| } | ||
|
|
||
| // txSpendsTicket returns true if the passed tx has an input that spends the | ||
| // specified output. | ||
| func txSpendsTicket(tx *wire.MsgTx, outputHash chainhash.Hash) bool { | ||
| for _, txIn := range tx.TxIn { | ||
| prevOut := &txIn.PreviousOutPoint | ||
| if prevOut.Index == 0 && prevOut.Hash == outputHash { | ||
| return true // Found spender. | ||
| } | ||
| } | ||
| return false | ||
| } | ||
|
|
||
| // pluralize suffixes the provided noun with "s" if n is not 1, then | ||
| // concatenates n and noun with a space between them. For example: | ||
| // | ||
| // (0, "biscuit") will return "0 biscuits" | ||
| // (1, "biscuit") will return "1 biscuit" | ||
| // (3, "biscuit") will return "3 biscuits" | ||
| func pluralize(n int, noun string) string { | ||
| if n != 1 { | ||
| noun += "s" | ||
| } | ||
| return fmt.Sprintf("%d %s", n, noun) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.