multi: Make GUI run blocking and wait for shutdown. #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajohi
approved these changes
Sep 14, 2023
This updates the gui.Run method to block until the context is canceled as expected and then adds a waitgroup across both it and the hub to allow for clean shutdown of both subsystems prior to shutdown. It also moves the initial connection and work acquisition prior to launching the subsystems to avoid launching them at all in the event of an error that would prevent the hub from initializing.
davecgh
force-pushed
the
block_run_and_wait
branch
from
4315c33
to
718522d
Compare
jholdstock
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the gui.Run method to block until the context is canceled as expected and then adds a waitgroup across both it and the hub to allow for clean shutdown of both subsystems prior to shutdown.
It also moves the initial connection and work acquisition prior to launching the subsystems to avoid launching them at all in the event of an error that would prevent the hub from initializing.