pool: Keep hub waitgroup local. #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The waitgroup for the hub is currently being passed down into all various configuration structs for each of the goroutines it runs which requires a lot of plumbing and is quite error prone. This addresses that by modifying the logic to keep the hub waitgroup local to the run method and removes the aforementioned unnecessary plumbing. These changes have also exposed an issue with endpoint.run in that it never terminates, but this commit does not fix that issue.
davecgh
force-pushed
the
local_hug_waitgroup
branch
from
fb088e0
to
f9ffa9e
Compare
jholdstock
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The waitgroup for the hub is currently being passed down into all various configuration structs for each of the goroutines it runs which requires a lot of plumbing and is quite error prone.
This addresses that by modifying the logic to keep the hub waitgroup local to the run method and removes the aforementioned unnecessary plumbing.
These changes have also exposed an issue with endpoint.run in that it never terminates, but this commit does not fix that issue.